Hyperdimensional strings

Imagen de gwolf
Submitted by gwolf on Mié, 01/14/2009 - 16:41

I am stunned no more people have been bitten by this. Or at least, the Intarweb has not heard about it. Censorship perhaps? I haven't researched more into the causes, but anyway...
I was pushing a project I have had lingering for some time from Rails 2.0.x to 2.1.x (yes, 2.2 is already out there, but 2.1 is the version that will ship with Lenny) - The changes should not be too invasive, as it is a minor release, but there are some quite noticeable changes.
Anyway... What was the problem? Take this very simple migration:

  1. class CreatePeople < ActiveRecord::Migration
  2.   def self.up
  3.     create_table :people do |t|
  4.       t.column :login, :string, :null => false
  5.       t.column :passwd, :string, :null => false
  6.       t.column :firstname, :string, :null => false
  7.       t.column :famname, :string, :null => false
  8.       t.column :email, :string
  9.  
  10.       t.column :pw_salt, :string
  11.       t.column :created_at, :timestamp
  12.       t.column :last_login_at, :timestamp
  13.     end
  14.   end
  15.  
  16.   def self.down
  17.     drop_table :people
  18.   end
  19. end

The problem is that PostgreSQL refuses to create a hyperdimensional string field. I offer this here to you, line-wrapped by me for your convenience.

  1. PGError: ERROR:  syntax error at OR near "("
  2. LINE 1: ...serial PRIMARY KEY, "login" character varying(255)(255) NOT ...
  3.                                                              ^
  4. : CREATE TABLE "people" ("id" serial PRIMARY KEY, 
  5.           "login" character varying(255)(255) NOT NULL, 
  6.           "passwd" character varying(255)(255)(255) NOT NULL, 
  7.           "firstname" character varying(255)(255)(255)(255) NOT NULL, 
  8.           "famname" character varying(255)(255)(255)(255)(255) NOT NULL,
  9.           "email" character varying(255)(255)(255)(255)(255)(255) DEFAULT NULL NULL,
  10.           "pw_salt" character varying(255)(255)(255)(255)(255)(255)(255) DEFAULT NULL NULL, 
  11.           "created_at" timestamp DEFAULT NULL NULL, "last_login_at" timestamp DEFAULT NULL NULL)

Beautiful. Now I can store strings not only as character vectors, but as planes, cubes, hypercubes, and any other hyperdimensional construct! Are we approaching quantum computers?
What is really striking is that... I found only one occurrence on tha net of this bug - one and a half years ago, in Ola Bini's blog. No stunned users looking for the culprit, no further reports... Strange.
Still, the bug was fixed in Rails 2.2 about half a year ago, although not in revisions of earlier versions. I will request the patch to be applied to earlier versions as well. Sigh.